Corrected wrong Dijkstra priority queue implementation #909
Merged
Conversation
poyea
approved these changes
Jun 23, 2019
poyea
left a comment
poyea
left a comment
Member
There was a problem hiding this comment.
I agree with this. Thank you for your pull request!🤩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given visited is a list(), "if v in visited:" is a O(n) operation in python which yields more complexity to this implementation as the if statement is nested in a for loop. Changing visited into a hash set grants only O(1) for checking "if v in visited:".